-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate submit proposal commands to sdk v50 #1379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/provider
Assigned automatically by the PR labeler
label
Oct 31, 2023
MSalopek
changed the title
feat: Migrate submit proposal commands
feat: Migrate submit proposal commands to sdk v50
Nov 2, 2023
Waiting on cosmos/cosmos-sdk#18309 to be backported to v50 branch. |
bermuell
force-pushed
the
bernd/1361-v50-submit_proposal
branch
from
November 6, 2023 12:35
5f145bf
to
782ed55
Compare
github-actions
bot
added
C:Testing
Assigned automatically by the PR labeler
C:Build
Assigned automatically by the PR labeler
labels
Nov 6, 2023
bermuell
force-pushed
the
bernd/1361-v50-submit_proposal
branch
from
November 7, 2023 08:59
782ed55
to
275ae80
Compare
This reverts commit c264d4f.
MSalopek
reviewed
Nov 8, 2023
MSalopek
reviewed
Nov 8, 2023
MSalopek
reviewed
Nov 8, 2023
MSalopek
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Approve!
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate governance proposal from
tx submit-legacy-proposal
totx submit-proposal
forCloses: #1361
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)CHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change