Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate submit proposal commands to sdk v50 #1379

Merged
merged 17 commits into from
Nov 8, 2023

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Oct 31, 2023

Description

Migrate governance proposal from tx submit-legacy-proposal to tx submit-proposal for

  • ConsumerAdditionProposal
  • ConsumerRemovalProposal
  • ChangeRewardDenomsProposal

Closes: #1361


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release for both the consumer and provider

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Oct 31, 2023
@MSalopek MSalopek changed the title feat: Migrate submit proposal commands feat: Migrate submit proposal commands to sdk v50 Nov 2, 2023
@MSalopek
Copy link
Contributor

MSalopek commented Nov 2, 2023

Waiting on cosmos/cosmos-sdk#18309 to be backported to v50 branch.

@bermuell bermuell force-pushed the bernd/1361-v50-submit_proposal branch from 5f145bf to 782ed55 Compare November 6, 2023 12:35
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:Build Assigned automatically by the PR labeler labels Nov 6, 2023
@bermuell bermuell force-pushed the bernd/1361-v50-submit_proposal branch from 782ed55 to 275ae80 Compare November 7, 2023 08:59
@github-actions github-actions bot removed the C:Build Assigned automatically by the PR labeler label Nov 7, 2023
@github-actions github-actions bot removed the C:Testing Assigned automatically by the PR labeler label Nov 7, 2023
@bermuell bermuell marked this pull request as ready for review November 7, 2023 15:12
@bermuell bermuell requested a review from a team as a code owner November 7, 2023 15:12
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Approve!

@bermuell bermuell merged commit ca97abb into feat/v50-upgrade Nov 8, 2023
4 of 12 checks passed
@bermuell bermuell deleted the bernd/1361-v50-submit_proposal branch November 8, 2023 13:20
@bermuell bermuell self-assigned this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants